Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[MonologBridge][WebServerBundle] Add suggestions for using the log server#25026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.3frommaidmaid:fix-log-server
Dec 12, 2017

Conversation

@maidmaid
Copy link
Contributor

@maidmaidmaidmaid commentedNov 19, 2017•
edited
Loading

QA
Branch?3.3
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets/
LicenseMIT
Doc PR/

If you want launchserver:log, you need the monolog bridge and the VarDumper. Optionally, you need EL if you want useserver:log --filter.

ro0NL reacted with thumbs up emoji
@ro0NL
Copy link
Contributor

Related; should we patchisEnabled as well? If you load the webserverbundle based on a symfony/symfony project the CLI app crashes due a missing FormatterInterface from monolog/monolog.

maidmaid reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas added this to the3.3 milestoneNov 19, 2017
@fabpot
Copy link
Member

I'm personally 👎 on adding moresuggestions incomposer.json. I don't see how it adds value as I don't see why people would read those suggestions when installing a new dependency. That's more something for the docs.

@maidmaid
Copy link
ContributorAuthor

@ro0NL Well seen! I added this one.

@fabpot Indeed, these suggestions must appear in the documentation; however, I think suggestions' composer must match with the documentation. Personally, I sometimes launchcomposer suggest -v for discover the suggestions.

@nicolas-grekas
Copy link
Member

ping@fabpot still not sold? I'm still +1 on my side :)

@fabpot
Copy link
Member

@nicolas-grekas Let's say I'm just +0 on this.

@nicolas-grekas
Copy link
Member

Merging then, especially since suggestions are not displayed in Flex era.

@nicolas-grekas
Copy link
Member

Thank you@maidmaid.

@nicolas-grekasnicolas-grekas merged commitaca0ddd intosymfony:3.3Dec 12, 2017
nicolas-grekas added a commit that referenced this pull requestDec 12, 2017
…ng the log server (maidmaid)This PR was merged into the 3.3 branch.Discussion----------[MonologBridge][WebServerBundle] Add suggestions for using the log server| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | /| License       | MIT| Doc PR        | /If you want launch `server:log`, you need the monolog bridge and the VarDumper. Optionally, you need EL if you want use `server:log --filter`.Commits-------aca0ddd Add suggestions
@maidmaidmaidmaid deleted the fix-log-server branchDecember 12, 2017 09:10
nicolas-grekas added a commit that referenced this pull requestJan 3, 2018
…ists (kbond)This PR was merged into the 3.3 branch.Discussion----------[WebServerBundle] use interface_exists instead of class_exists| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aThis bug was introduced in#25026Commits-------dc3a94e use interface_exists instead of class_exists
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

6 participants

@maidmaid@ro0NL@fabpot@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp