NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DI] Fix by-type args injection#24978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

nicolas-grekas wants to merge1 commit intosymfony:masterfromnicolas-grekas:di-named-types

Closed

[DI] Fix by-type args injection#24978

nicolas-grekas wants to merge1 commit intosymfony:masterfromnicolas-grekas:di-named-types

Conversation

Copy link

Member

nicolas-grekas commentedNov 15, 2017

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

Three fixes:

arguments should have higher priority than bindings
$named arguments should have higher priority thanBy\TypeHint arguments
doubled same-type should work, not only the first should be wired

@sroze I might need your help for adding tests, would be awesome!

[DI] Fix by-type args injection

c0c08db

nicolas-grekas added this to the3.4 milestone

Nov 15, 2017

carsonbot added Status: Needs Review DependencyInjection Bug labels

Nov 15, 2017

Copy link

Contributor

sroze commentedNov 16, 2017•
edited
Loading

@nicolas-grekas can you give me a PHP class example that showcases what you try to solve? I can't reproduce the last issue 🤔

sroze mentioned this pull request

Nov 16, 2017

[DependencyInjection] Single typed argument can be applied on multiple parameters#24991

Merged

stof added a commit that referenced this pull request

Nov 17, 2017

bug#24991[DependencyInjection] Single typed argument can be applied…

8d7f6ed

… on multiple parameters (nicolas-grekas, sroze)This PR was merged into the 3.4 branch.Discussion----------[DependencyInjection] Single typed argument can be applied on multiple parameters| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | ø| License       | MIT| Doc PR        | øI'm@nicolas-grekas' test writer today. This makes the argument resolution working when injecting the same type multiple times (sub-set of PR#24978)Commits-------d512654 Test that named arguments are prioritized over typehintedbf7eeef Prove that change is working with tests2176be7 [DI] Fix by-type args injection