Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DomCrawler] Type fix Crawler:: discoverNamespace()#24975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Based on 3.x behavior
chalasr left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DomCrawler/Crawler.php#L1102
Also not sure that the@throws annotation is relevant, but that's another (2.7) topic.
stof commentedNov 16, 2017
Thank you@VolCh. |
This PR was merged into the 4.0-dev branch.Discussion----------[DomCrawler] Type fix Crawler:: discoverNamespace()Based on 3.x behavior| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? |no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |<!--- Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too).- Features and deprecations must be submitted against the master branch.- Please fill in this template according to the PR you're about to submit.- Replace this comment by a description of what your PR is solving.-->Commits-------e39e8c2 [DomCrawler] Fix return type Crawler:: discoverNamespace()
Based on 3.x behavior