Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Fix service arg resolver for controllers as array callables#24972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[HttpKernel] Fix service arg resolver for controllers as array callables#24972
Uh oh!
There was an error while loading.Please reload this page.
Conversation
sroze commentedNov 15, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
sroze commentedNov 15, 2017
AppVeyor's issue is unrelated. |
nicolas-grekas commentedNov 15, 2017
@sroze could you please squash the PR so that there are only two commits: mine and yours? |
Prove that the service value resolver will not work with the array notation
5a7fc76 tofc3d3bbComparesroze commentedNov 15, 2017
@nicolas-grekas done |
nicolas-grekas commentedNov 16, 2017
Thank you@sroze. |
…rray callables (sroze, nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[HttpKernel] Fix service arg resolver for controllers as array callables| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24970| License | MIT| Doc PR | øReplacing#24970 as I can't push tests directly to@nicolas-grekas' PR.> As spotted today during a Symfony 4 workshop at SymfonyCon Cluj, setting a controller as an array [SomeController::class, 'helloAction'] works, it is defined as a service, BUT the actions don't get the services as arguments. This is fixing it.Commits-------fc3d3bb [HttpKernel] Fix service arg resolver for controllers as array callablesa9e9f36 Add service value resolver tests Prove that the service value resolver will not work with the array notation
Uh oh!
There was an error while loading.Please reload this page.
Replacing#24970 as I can't push tests directly to@nicolas-grekas' PR.