Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpKernel] Fix service arg resolver for controllers as array callables#24972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@sroze
Copy link
Contributor

@srozesroze commentedNov 15, 2017
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#24970
LicenseMIT
Doc PRø

Replacing#24970 as I can't push tests directly to@nicolas-grekas' PR.

As spotted today during a Symfony 4 workshop at SymfonyCon Cluj, setting a controller as an array [SomeController::class, 'helloAction'] works, it is defined as a service, BUT the actions don't get the services as arguments. This is fixing it.

@srozesroze changed the base branch frommaster to3.4November 15, 2017 09:45
@sroze
Copy link
ContributorAuthor

sroze commentedNov 15, 2017
edited
Loading

Not sure why fabbot complains about the PR header 🤔 It looks like fabbot do not support copy/pasted tables :)

@sroze
Copy link
ContributorAuthor

AppVeyor's issue is unrelated.

@nicolas-grekas
Copy link
Member

@sroze could you please squash the PR so that there are only two commits: mine and yours?

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneNov 15, 2017
srozeand others added2 commitsNovember 15, 2017 13:29
Prove that the service value resolver will not work with the array notation
@srozesrozeforce-pushed thefix-service-resolver-with-tests branch from5a7fc76 tofc3d3bbCompareNovember 15, 2017 11:29
@sroze
Copy link
ContributorAuthor

@nicolas-grekas done

@nicolas-grekas
Copy link
Member

Thank you@sroze.

@nicolas-grekasnicolas-grekas merged commitfc3d3bb intosymfony:3.4Nov 16, 2017
nicolas-grekas added a commit that referenced this pull requestNov 16, 2017
…rray callables (sroze, nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[HttpKernel] Fix service arg resolver for controllers as array callables| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#24970| License       | MIT| Doc PR        | øReplacing#24970 as I can't push tests directly to@nicolas-grekas' PR.> As spotted today during a Symfony 4 workshop at SymfonyCon Cluj, setting a controller as an array [SomeController::class, 'helloAction'] works, it is defined as a service, BUT the actions don't get the services as arguments. This is fixing it.Commits-------fc3d3bb [HttpKernel] Fix service arg resolver for controllers as array callablesa9e9f36 Add service value resolver tests Prove that the service value resolver will not work with the array notation
This was referencedNov 21, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@sroze@nicolas-grekas@xabbuh@Simperfit@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp