Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Just skip PHP'ssession_set_save_handler, not the fullsetSaveHandler#24946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c49af5c tob93d835Compare| * @throws \InvalidArgumentException | ||
| */ | ||
| publicfunctionsetSaveHandler($saveHandler =null) | ||
| publicfunctionsetSaveHandler($saveHandler =null,bool$updatePhpHandler =true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
adding a new argument to a public method is a BC break (breaks child classes), should usefunc_num_args()func_get_arg()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good point 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@chalasr updated 👍
9d04017 toeeba04cCompareeeba04c to5cada3aComparesession_set_save_handler, not the full `setSaveHand…session_set_save_handler, not the fullsetSaveHandler…kas, sroze)This PR was merged into the 2.7 branch.Discussion----------[HttpFoundation] Fix session-related BC break| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24941,#24934,#24947 and#24946| License | MIT| Doc PR | -Conservative fix.Commits-------38186aa [HttpFoundation] Add test3eaa188 [HttpFoundation] Fix session-related BC break
Uh oh!
There was an error while loading.Please reload this page.
We've removed the
setSaveHandlercall while all we needed was remove the call to PHP'ssession_set_save_handlerfunction.