Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Wire the translation.reader service instead of deprecated translation.loader in commands#24943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromogizanagi:fix/3.4/trans_commands_use_reader
Nov 13, 2017
Merged

[FrameworkBundle] Wire the translation.reader service instead of deprecated translation.loader in commands#24943

fabpot merged 1 commit intosymfony:3.4fromogizanagi:fix/3.4/trans_commands_use_reader
Nov 13, 2017

Conversation

@ogizanagi
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsN/A
LicenseMIT
Doc PRN/A

to get rid of the following deprec:

The class "Symfony\Bundle\FrameworkBundle\Translation\TranslationLoader" is deprecated since version 3.4 and will be removed in 4.0. Use "Symfony\Component\Translation\Reader\TranslationReader"

hiddewie reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@ogizanagi.

@fabpotfabpot merged commit8da283b intosymfony:3.4Nov 13, 2017
fabpot added a commit that referenced this pull requestNov 13, 2017
…ead of deprecated translation.loader in commands (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Wire the translation.reader service instead of deprecated translation.loader in commands| Q             | A| ------------- | ---| Branch?       | 3.4 <!-- see comment below -->| Bug fix?      | yes| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/Ato get rid of the following deprec:> The class "Symfony\Bundle\FrameworkBundle\Translation\TranslationLoader" is deprecated since version 3.4 and will be removed in 4.0. Use "Symfony\Component\Translation\Reader\TranslationReader"Commits-------8da283b [FrameworkBundle] Wire the translation.reader service instead of deprecated translation.loader in commands
@ogizanagiogizanagi deleted the fix/3.4/trans_commands_use_reader branchNovember 13, 2017 15:11
@kbond
Copy link
Member

@ogizanagi I'm still seeing a deprecation message when building the container.

@ogizanagi
Copy link
ContributorAuthor

ogizanagi commentedNov 13, 2017•
edited
Loading

@kbond : This is not released yet. Did you apply this patch locally but still having this deprec?

@kbond
Copy link
Member

Yes, latest 3.4 branch

@ogizanagi
Copy link
ContributorAuthor

Could you please check for occurrences oftranslation.loader in your project? Any vendor likely to use the deprecated service rather thantranslation.reader?

@kbond
Copy link
Member

No and I see it on a fresh symfony-standard app (downloaded 3.4, ran composer update, enabled translation inapp/config/config.yml)

@kbond
Copy link
Member

I was able to stop the dep message by removing this line:

$container->getDefinition('translation.loader')->setPrivate(true);

But I'm not sure why that worked...

@ogizanagi
Copy link
ContributorAuthor

I've opened#24959 to keep track of this. Thanks for the report. :)

kbond reacted with thumbs up emoji

This was referencedNov 21, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ogizanagi@fabpot@kbond@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp