Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Filesystem] toIterable() in favor of toIterator()#24928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ro0NL wants to merge2 commits intosymfony:3.4fromro0NL:filesystem-iterable
Closed

[Filesystem] toIterable() in favor of toIterator()#24928

ro0NL wants to merge2 commits intosymfony:3.4fromro0NL:filesystem-iterable

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedNov 11, 2017•
edited
Loading

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

Enables to leverage iterable type as of 4.0, but really to avoid any uselessArrayObject inits.

jvasseur reacted with thumbs up emoji
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

no fan of such changes, but ok :)

@ro0NL
Copy link
ContributorAuthor

to further clarify; im spottingarray|\Traversable API in master; probably to be intended asiterable type. Which we do favor.. no? :)

@nicolas-grekas
Copy link
Member

iterable didn't exist when we addedarray|\Traversable
but we're not (I'm not at least) going to change all of them for the fun of it...

@fabpot
Copy link
Member

Could be merged in 3.4, but not in 2.7 anyway.

@ro0NL
Copy link
ContributorAuthor

Hm, why not? Safe change to me. Without involving php71 feats, this is indeed about changing the implementation from iterators to iterables; enabling removal of ArrayObject inits.

Done on 2.7 to avoid merge conflicts and not havetoIterator(): iterable behavior 👼

@fabpot
Copy link
Member

That's not a bug fix, so it does not qualify for 2.7. We've been doing too many such changes in lower branches in the recent history. But that was a mistake.

@ro0NLro0NL changed the base branch from2.7 to3.4November 12, 2017 17:46
@ro0NLro0NL changed the title[Filesystem][2.7] toIterable() in favor of toIterator()[Filesystem] toIterable() in favor of toIterator()Nov 12, 2017
@fabpot
Copy link
Member

Thank you@ro0NL.

fabpot added a commit that referenced this pull requestNov 12, 2017
This PR was squashed before being merged into the 3.4 branch (closes#24928).Discussion----------[Filesystem] toIterable() in favor of toIterator()| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->Enables to leverage iterable type as of 4.0, but really to avoid any useless `ArrayObject` inits.Commits-------36462d6 [Filesystem] toIterable() in favor of toIterator()
@ro0NLro0NL deleted the filesystem-iterable branchNovember 13, 2017 08:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ro0NL@nicolas-grekas@fabpot@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp