Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Filesystem] Replace remaing docblocks by type-hints#24926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * @return \Traversable | ||
| */ | ||
| privatefunctiontoIterator($files) | ||
| privatefunctiontoIterable($files):iterable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the name change is debatable, and creates useless diff lines, thus won't help merges
should be reverted IMHO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hence#24928 :)
| } | ||
| return$files; | ||
| returnis_iterable($files) ?$files :array($files); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this implementation is not compatible with the previous, won't it create BC breaks f the return is forwarded as return value of a public method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
private API :) checked all usages; they truly rely on aforeachable value.
Uh oh!
There was an error while loading.Please reload this page.
Partially forgotten in#24722 as only
private getSchemeAndHierarchywas updated.Adds simplification of
toIterator.edit: wrong labels.