Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Bridge/ProxyManager] Remove direct reference to value holder property#24906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
MemberAuthor
nicolas-grekas commentedNov 10, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
To be merged up to 3.4, but not needed in master asOcramius/ProxyManager#396 will do it there. |
Contributor
sroze commentedNov 10, 2017
On a scale from 0 to 10... how likely are you going to be able to write tests for this one? 😅 |
MemberAuthor
nicolas-grekas commentedNov 10, 2017
0 |
fabpot approved these changesNov 10, 2017
Member
fabpot commentedNov 10, 2017
Thank you@nicolas-grekas. |
fabpot added a commit that referenced this pull requestNov 10, 2017
…der property (nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[Bridge/ProxyManager] Remove direct reference to value holder property| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#23110| License | MIT| Doc PR | -ThisfixesOcramius/ProxyManager#394 on Symfony's side, because proxy-manager v1 is not maintained anymore, but is the only one that works on PHP 5.3/5.5, which we still support.Cannot be tested easily (but code is run by the existing test suite.)Commits-------af9d644 [Bridge/ProxyManager] Remove direct reference to value holder property
This was referencedNov 10, 2017
Merged
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
ThisfixesOcramius/ProxyManager#394 on Symfony's side, because proxy-manager v1 is not maintained anymore, but is the only one that works on PHP 5.3/5.5, which we still support.
Cannot be tested easily (but code is run by the existing test suite.)