Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Specifically inject the debug dispatcher in the collector#24888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:2.7fromogizanagi:fix/2.7/event_collector_inject_traceable_dispatcherNov 10, 2017
Merged
[FrameworkBundle] Specifically inject the debug dispatcher in the collector#24888
fabpot merged 1 commit intosymfony:2.7fromogizanagi:fix/2.7/event_collector_inject_traceable_dispatcherNov 10, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
chalasr approved these changesNov 9, 2017
20uf approved these changesNov 10, 2017
nicolas-grekas approved these changesNov 10, 2017
fabpot approved these changesNov 10, 2017
Member
fabpot commentedNov 10, 2017
Thank you@ogizanagi. |
fabpot added a commit that referenced this pull requestNov 10, 2017
… in the collector (ogizanagi)This PR was merged into the 2.7 branch.Discussion----------[FrameworkBundle] Specifically inject the debug dispatcher in the collector| Q | A| ------------- | ---| Branch? | 2.7 <!-- see comment below -->| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/AThis ensures we always collect data about events, even when the `event_dispatcher` service is decorated, no matter the decoration order.Commits-------7b3a641 [FrameworkBundle] Specifically inject the debug dispatcher in the collector
This was referencedNov 10, 2017
Merged
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures we always collect data about events, even when the
event_dispatcherservice is decorated, no matter the decoration order.