Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebserverBundle] fixed the bug that caused that the webserver would …#24881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[WebserverBundle] fixed the bug that caused that the webserver would …#24881
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…start anyway even you said N.
| )); | ||
| if ($io->ask('Do you want to execute <info>server:run</info> immediately? [yN]',false)) { | ||
| if ($io->confirm('Do you want to execute <info>server:run</info> immediately? [yN]',false)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[yN] should be removed (it's automatically added when usingconfirm())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Removed the yN and committed. Thanks.
chalasr commentedNov 9, 2017
FYI it seems like your git user is not recognized by github, you probably need to register a new email address on github from the output of |
ro0NL left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hm i recognize this change :) seehttps://github.com/symfony/symfony/pull/22317/files#diff-15a026db1c07d66e0572d8302ad7d717
to mergers: already in 3.4
SerkanYildiz commentedNov 9, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
True. It is already fixed in 3.4 :) |
fabpot commentedNov 9, 2017
Thank you@SerkanYildiz. |
…rver would … (Serkan Yildiz)This PR was squashed before being merged into the 3.3 branch (closes#24881).Discussion----------[WebserverBundle] fixed the bug that caused that the webserver would …Fixed the bug that caused that the webserver would start anyway even you said N.| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24879| License | MIT| Doc PR | /Commits-------c256782 [WebserverBundle] fixed the bug that caused that the webserver would …
chalasr commentedNov 9, 2017
Congrats for your first Symfony PR@SerkanYildiz! |
SerkanYildiz commentedNov 9, 2017
Thank you guys! |
Fixed the bug that caused that the webserver would start anyway even you said N.