Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Prevent PHP from sending Last-Modified on session start#24878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
sroze left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The approach definitely makes sense to me 👍
| publicfunctionopen($savePath,$sessionName) | ||
| { | ||
| $this->sessionName =$sessionName; | ||
| if (!headers_sent() && !ini_get('session.cache_limiter')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't we raise a warning or something in!ini_get('session.cache_limiter') && headers_sent() ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not sure, there are many similar checks in the code base already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Well,this one convinced me... 😅
fabpot commentedNov 9, 2017
Thank you@nicolas-grekas. |
… session start (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[HttpFoundation] Prevent PHP from sending Last-Modified on session start| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24849| License | MIT| Doc PR | -I really don't know why PHP sends this Last-Modified header.Let's bypass that and throw headers ourselves instead.Commits-------2c0dc74 [HttpFoundation] Prevent PHP from sending Last-Modified on session start
| $options +=array( | ||
| 'cache_limiter' =>'private_no_expire', | ||
| 'cache_limiter' =>'', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the phpdoc with the standard options is wrong now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed incf4eb46
I really don't know why PHP sends this Last-Modified header.
Let's bypass that and throw headers ourselves instead.