Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] Fixed the .form-check-input class in the bs4 templates#24874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
vudaltsov wants to merge2 commits intosymfony:3.4fromvudaltsov:bs4-fix

Conversation

@vudaltsov
Copy link
Contributor

@vudaltsovvudaltsov commentedNov 9, 2017•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

If I am not mistaken, theform-check-input class should always be present in inputs of checkboxes and radios

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedNov 10, 2017•
edited
Loading

the composer.json file of the Twig bridge needs to be updated also, "conflicts" section
"symfony/form": "<3.4-beta4|~4.0,<4.0-beta4",

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneNov 10, 2017
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(failure on deps=low is a CI bug)

@fabpot
Copy link
Member

Thank you@vudaltsov.

fabpot added a commit that referenced this pull requestNov 12, 2017
…templates (vudaltsov)This PR was squashed before being merged into the 3.4 branch (closes#24874).Discussion----------[TwigBridge] Fixed the .form-check-input class in the bs4 templates| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |If I am not mistaken, the `form-check-input` class should always be present in inputs of checkboxes and radiosCommits-------95a90e4 [TwigBridge] Fixed the .form-check-input class in the bs4 templates
@fabpotfabpot closed thisNov 12, 2017
This was referencedNov 12, 2017
@vudaltsovvudaltsov deleted the bs4-fix branchDecember 14, 2018 10:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@vudaltsov@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp