Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[YAML] Allow to parse custom tags when linting yaml files#24870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedNov 9, 2017
Since the tag parsing feature is opt-in it may be worth it to make at an opt-in feature of the lint command too. |
pierredup commentedNov 9, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I did initially add a new option to the command to enable the flag, but wasn't sure if that would count as a new feature then instead of a bug fix? |
chalasr commentedNov 9, 2017
Seems like a feature yes, although it should have been added at time the constant has been introduced. |
pierredup commentedNov 9, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Linting the yaml files is part of our build process, so all our builds keeps failing because of this. So if this can only go in as a new feature in 4.1, then we won't be able to lint yaml files until May next year and after upgrading to Symfony 4 (or we must duplicate the logic in our application) unless this can be enabled by default without the additional option, but that might cause some false-positives if someone hasn't enabled custom tags |
fabpot commentedNov 10, 2017
Thank you@pierredup. |
…(pierredup)This PR was squashed before being merged into the 3.3 branch (closes#24870).Discussion----------[YAML] Allow to parse custom tags when linting yaml files| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/AWhen using custom tags in yaml, currently the `lint:yaml` command fails since the flag `Yaml::PARSE_CUSTOM_TAGS` is not passed throughCommits-------d8dd91d [YAML] Allow to parse custom tags when linting yaml files
Uh oh!
There was an error while loading.Please reload this page.
When using custom tags in yaml, currently the
lint:yamlcommand fails since the flagYaml::PARSE_CUSTOM_TAGSis not passed through