Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[YAML] Allow to parse custom tags when linting yaml files#24870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
pierredup wants to merge2 commits intosymfony:3.3frompierredup:yaml-tags-lint

Conversation

@pierredup
Copy link
Contributor

@pierreduppierredup commentedNov 8, 2017
edited
Loading

QA
Branch?3.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsN/A
LicenseMIT
Doc PRN/A

When using custom tags in yaml, currently thelint:yaml command fails since the flagYaml::PARSE_CUSTOM_TAGS is not passed through

@xabbuh
Copy link
Member

Since the tag parsing feature is opt-in it may be worth it to make at an opt-in feature of the lint command too.

@pierredup
Copy link
ContributorAuthor

pierredup commentedNov 9, 2017
edited
Loading

I did initially add a new option to the command to enable the flag, but wasn't sure if that would count as a new feature then instead of a bug fix?

@chalasr
Copy link
Member

Seems like a feature yes, although it should have been added at time the constant has been introduced.

@pierredup
Copy link
ContributorAuthor

pierredup commentedNov 9, 2017
edited
Loading

Linting the yaml files is part of our build process, so all our builds keeps failing because of this. So if this can only go in as a new feature in 4.1, then we won't be able to lint yaml files until May next year and after upgrading to Symfony 4 (or we must duplicate the logic in our application) unless this can be enabled by default without the additional option, but that might cause some false-positives if someone hasn't enabled custom tags

@fabpot
Copy link
Member

Thank you@pierredup.

fabpot added a commit that referenced this pull requestNov 10, 2017
…(pierredup)This PR was squashed before being merged into the 3.3 branch (closes#24870).Discussion----------[YAML] Allow to parse custom tags when linting yaml files| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | N/A| License       | MIT| Doc PR        | N/AWhen using custom tags in yaml, currently the `lint:yaml` command fails since the flag `Yaml::PARSE_CUSTOM_TAGS` is not passed throughCommits-------d8dd91d [YAML] Allow to parse custom tags when linting yaml files
@fabpotfabpot closed thisNov 10, 2017
This was referencedNov 10, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

6 participants

@pierredup@xabbuh@chalasr@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp