Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[TwigBundle] Add default Twig templates path as a container param#24840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromemodric:twig_default_path
Nov 10, 2017

Conversation

@emodric
Copy link
Contributor

QA
Branch?3.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#24839
LicenseMIT
Doc PRN/A

Adds atwig.default_path container param for easier access to this config in compiler passes.

yceruto and linaori reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@emodric.

emodric reacted with hooray emoji

@fabpotfabpot merged commit81b38ec intosymfony:3.4Nov 10, 2017
fabpot added a commit that referenced this pull requestNov 10, 2017
…ner param (emodric)This PR was merged into the 3.4 branch.Discussion----------[TwigBundle] Add default Twig templates path as a container param| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#24839| License       | MIT| Doc PR        | N/AAdds a `twig.default_path` container param for easier access to this config in compiler passes.Commits-------81b38ec [TwigBundle] Add default Twig templates path as a container param
fabpot added a commit that referenced this pull requestNov 11, 2017
… and convention (yceruto)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Add default translations path option and convention| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | ToDoSimilar to Twig default path, this proposal adds a `default_path` option under `translator` config:```yamlframework:    translator:        default_path: '%kernel.project_dir%/config/translations'```adding this default path to the discovered translations dirs. Thus, overriding bundle translations is possible by using this new convention: `config/translations/<BundleName>/messages.en.xlf`.Also a new container parameter `%translator.default_path%` is defined by external purpose (similar to#24840)Note: The current convention `%kernel.root_dir%/Resources/translations` path has priority over the new one.TODO:- [x] Add more tests about the new path- [x] Update changelogCommits-------1a8b1b4 Add default translations path option and convention
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@20uf20uf20uf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@emodric@fabpot@nicolas-grekas@20uf@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp