Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBundle] Add default Twig templates path as a container param#24840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesNov 7, 2017
2 tasks
20uf approved these changesNov 7, 2017
Member
fabpot commentedNov 10, 2017
Thank you@emodric. |
fabpot added a commit that referenced this pull requestNov 10, 2017
…ner param (emodric)This PR was merged into the 3.4 branch.Discussion----------[TwigBundle] Add default Twig templates path as a container param| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24839| License | MIT| Doc PR | N/AAdds a `twig.default_path` container param for easier access to this config in compiler passes.Commits-------81b38ec [TwigBundle] Add default Twig templates path as a container param
fabpot added a commit that referenced this pull requestNov 11, 2017
… and convention (yceruto)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Add default translations path option and convention| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | ToDoSimilar to Twig default path, this proposal adds a `default_path` option under `translator` config:```yamlframework: translator: default_path: '%kernel.project_dir%/config/translations'```adding this default path to the discovered translations dirs. Thus, overriding bundle translations is possible by using this new convention: `config/translations/<BundleName>/messages.en.xlf`.Also a new container parameter `%translator.default_path%` is defined by external purpose (similar to#24840)Note: The current convention `%kernel.root_dir%/Resources/translations` path has priority over the new one.TODO:- [x] Add more tests about the new path- [x] Update changelogCommits-------1a8b1b4 Add default translations path option and convention
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
twig.default_pathcontainer param for easier access to this config in compiler passes.