Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType#24837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromostrolucky:patch-10
Nov 9, 2017

Conversation

@ostrolucky
Copy link
Contributor

@ostroluckyostrolucky commentedNov 6, 2017•
edited by nicolas-grekas
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Unfortunately I didn't test#24802 with expanded option set to true, sorry about that. Without this fix, it applies form error style twice.

Before:
screenshot from 2017-11-06 10 31 55

After:
screenshot from 2017-11-06 10 32 40

apetitpa reacted with thumbs up emoji
@ostrolucky
Copy link
ContributorAuthor

ostrolucky commentedNov 6, 2017•
edited
Loading

Note that this could break user space choice widgets which rely onis valid :/ But hey, this is BS4 only and they can still use errors|length. Still, better ideas welcome.

{%-else -%}
{%-ifnotvalid -%}
{%-setattr=attr|merge({class: (attr.class|default('') ~' form-control is-invalid')|trim}) %}
{%setvalid=true %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about instead just passingtrue in theform_widget() call below?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, that works too. Thanks

@nicolas-grekasnicolas-grekas changed the title[TwigBridge] [Bootstrap 4] Fix validation error design for expanded c…[TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceTypeNov 7, 2017
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneNov 7, 2017
@fabpot
Copy link
Member

Thank you@ostrolucky.

@fabpotfabpot merged commit39083a2 intosymfony:3.4Nov 9, 2017
fabpot added a commit that referenced this pull requestNov 9, 2017
… expanded choiceType (ostrolucky)This PR was merged into the 3.4 branch.Discussion----------[TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Unfortunately I didn't test#24802 with expanded option set to true, sorry about that. Without this fix, it applies form error style twice.Before:![screenshot from 2017-11-06 10 31 55](https://user-images.githubusercontent.com/496233/32434235-c13c02f8-c2dd-11e7-97da-6bfa312c5825.png)After:![screenshot from 2017-11-06 10 32 40](https://user-images.githubusercontent.com/496233/32434252-d30c2224-c2dd-11e7-86d6-fd06af3ef753.png)Commits-------39083a2 [TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType
This was referencedNov 12, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@ostrolucky@fabpot@xabbuh@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp