Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Fix the "almost-circular refs" fix#24828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas added a commit that referenced this pull requestNov 5, 2017
This PR was merged into the 3.4 branch.Discussion----------[DI] Fix the "almost-circular refs" fix| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Inlining adds to the complexity, now properly handled.Commits-------db12a98 [DI] Fix the "almost-circular refs" fix
Contributor
sroze commentedNov 6, 2017
🤠 😜 |
nicolas-grekas added a commit that referenced this pull requestNov 20, 2017
…grekas)This PR was merged into the 3.4 branch.Discussion----------[DI] Analyze setter-circular deps more precisely| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24950| License | MIT| Doc PR | -This PR reverts the effect of#24828 and#24822 on fixtures, except for the new behavior these PRs introduced, which was mostly fine, but missed a few cases.This PR now uses the reference graph to precisely decide which services need circular dependency care, and does not touch the other ones.Commits-------9cc4a21 [DI] Analyze setter-circular deps more precisely
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inlining adds to the complexity, now properly handled.