Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge] [Bootstrap 4] Fix hidden errors#24802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ddaf997 toeff3896Comparefabpot approved these changesNov 5, 2017
Member
fabpot commentedNov 5, 2017
Thank you@ostrolucky. |
fabpot added a commit that referenced this pull requestNov 5, 2017
This PR was merged into the 3.4 branch.Discussion----------[TwigBridge] [Bootstrap 4] Fix hidden errors| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24801| License | MIT| Doc PR | -Fixes displaying errors for:- Symfony\Component\Form\Extension\Core\Type\BirthdayType- Symfony\Component\Form\Extension\Core\Type\CheckboxType- Symfony\Component\Form\Extension\Core\Type\DateIntervalType- Symfony\Component\Form\Extension\Core\Type\DateTimeType- Symfony\Component\Form\Extension\Core\Type\DateType- Symfony\Component\Form\Extension\Core\Type\FileType- Symfony\Component\Form\Extension\Core\Type\RadioType- Symfony\Component\Form\Extension\Core\Type\TimeType<table><tr><th>Layout</th><th>Before</th><th>After</th></tr><tr><td>vertical</td><td valign="top"><img src="https://user-images.githubusercontent.com/496233/32405939-1b4c92c8-c16f-11e7-9b21-8af296aa8d94.png" width="400" alt="less validation errors shown in vertical bs4 layout" /></td><td valign="top"><img src="https://user-images.githubusercontent.com/496233/32405935-008a3d8c-c16f-11e7-8155-2a51ab55ae9a.png" width="400" alt="more validation errors shown in vertical bs4 layout" /></td></tr><tr><td>horizontal</td><td valign="top"><img src="https://user-images.githubusercontent.com/496233/32405984-213b432c-c170-11e7-832a-d94c7f7ddf07.png" width="400" alt="less validation errors shown in bs4 horizontal layout" /></td><td valign="top"><img src="https://user-images.githubusercontent.com/496233/32406022-bd25bf92-c170-11e7-893d-f071225f8273.png" width="400" alt="more validation errors shown" /></td></tr></table>Commits-------5810983 Fix displaying errors for bootstrap 4
symfony-splitter pushed a commit to symfony/twig-bridge that referenced this pull requestNov 9, 2017
… expanded choiceType (ostrolucky)This PR was merged into the 3.4 branch.Discussion----------[TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Unfortunately I didn't testsymfony/symfony#24802 with expanded option set to true, sorry about that. Without this fix, it applies form error style twice.Before:After:Commits-------39083a2067 [TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType
fabpot added a commit that referenced this pull requestNov 9, 2017
… expanded choiceType (ostrolucky)This PR was merged into the 3.4 branch.Discussion----------[TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Unfortunately I didn't test#24802 with expanded option set to true, sorry about that. Without this fix, it applies form error style twice.Before:After:Commits-------39083a2 [TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes displaying errors for: