Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass#24796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromlyrixx:phpunit
Nov 3, 2017

Conversation

@lyrixx
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

@lyrixx
Copy link
MemberAuthor

Hmm, I tried to add a test but it's not really possible.

@xabbuh
Copy link
Member

When can it happen that this method does not exist?

@lyrixx
Copy link
MemberAuthor

lyrixx commentedNov 2, 2017
edited
Loading

Ah yes I removed the test. but it is still in the PR title and commit message ;)
Try to throw an exception in thesetUpBeforeClass and you will see.
(Note I did not dig in PHPUnit to find the root cause. I'm not sure I want to :D )

@xabbuh
Copy link
Member

Could it be related to$test being an instance ofTestSuite but notTestCase?

@lyrixx
Copy link
MemberAuthor

I don't know. What do you have in mind ?

@xabbuh
Copy link
Member

We could then useinstanceof instead.

@lyrixx
Copy link
MemberAuthor

I was pretty sure you are going to say that.
using instanceof will be a bit boring because we manage many PHPUnit version (pear convention vs namespace :/)

@xabbuh
Copy link
Member

There is an alias for the namespaced class in PHPUnit 4.8 and 5.x. :)

@lyrixx
Copy link
MemberAuthor

@xabbuh It should be ok

@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commit25e0117 intosymfony:3.4Nov 3, 2017
fabpot added a commit that referenced this pull requestNov 3, 2017
… something goes wrong in Test::setUpBeforeClass (lyrixx)This PR was merged into the 3.4 branch.Discussion----------[PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Commits-------25e0117 [PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass
@lyrixxlyrixx deleted the phpunit branchNovember 3, 2017 14:13
This was referencedNov 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lyrixx@xabbuh@fabpot@Simperfit@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp