Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] Fix TraceableValidator is reset on data collector instantiation#24770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
fabpot commentedOct 31, 2017
Tagging with |
ContributorAuthor
ogizanagi commentedOct 31, 2017
Updated |
fabpot approved these changesOct 31, 2017
Member
fabpot commentedOct 31, 2017
Thank you@ogizanagi. |
fabpot added a commit that referenced this pull requestOct 31, 2017
…tor instantiation (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[Validator] Fix TraceableValidator is reset on data collector instantiation| Q | A| ------------- | ---| Branch? | 3.4 <!-- see comment below -->| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/ACalling reset from the constructor is wrong in this case as it'll reset the `TraceableValidator`, which means you'll never get collected data on the first request as the collector is instantiated after (on kernel response).Another option would be to tag the `debug.validator` service with `kernel.reset` and remove the reset call from the collector.Commits-------f5855fb [Validator] Fix TraceableValidator is reset on data collector instantiation
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Calling reset from the constructor is wrong in this case as it'll reset the
TraceableValidator, which means you'll never get collected data on the first request as the collector is instantiated after (on kernel response).Another option would be to tag the
debug.validatorservice withkernel.resetand remove the reset call from the collector.