Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] add Early Hints to Reponse to fix test#24764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9d9d56a to70b68aeCompare70b68ae toc2b4ea2CompareContributorAuthor
Simperfit commentedOct 31, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Travis seems broken.. :( EDIT: travis back up |
chalasr approved these changesOct 31, 2017
c2b4ea2 to0c913fdCompareMember
chalasr commentedOct 31, 2017
The test uses IANA HTTP codes as data provider, and phpdoc says it should be complete. |
Member
dunglas commentedOct 31, 2017
Should be merged in 2.7, indeed. 👍 |
0c913fd todbc2f7bCompareContributorAuthor
Simperfit commentedOct 31, 2017
PR Rebased |
ogizanagi approved these changesOct 31, 2017
Contributor
ogizanagi commentedOct 31, 2017
You should re-trigger a travis build by amending your commit. |
dbc2f7b to71ad77aCompareContributorAuthor
Simperfit commentedOct 31, 2017
done@ogizanagi |
fabpot approved these changesOct 31, 2017
Member
fabpot commentedOct 31, 2017
Thank you@Simperfit. |
fabpot added a commit that referenced this pull requestOct 31, 2017
…imperfit)This PR was merged into the 2.7 branch.Discussion----------[HttpFoundation] add Early Hints to Reponse to fix test| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none| License | MIT| Doc PR | not neededThis line seems to be needed in order to fix the tests, maybe it has been forgot in merge ?Commits-------71ad77a [HttpFoundation] add Early Hints in Reponse to fix test
Merged
This was referencedNov 5, 2017
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This line seems to be needed in order to fix the tests, maybe it has been forgot in merge ?