Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] ExpressionValidator should use OBJECT_TO_STRING#24750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Simperfit
Copy link
Contributor

@SimperfitSimperfit commentedOct 30, 2017•
edited
Loading

…value in message

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#24595
LicenseMIT
Doc PRWill do.

Hanmac reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

For which branch is this PR?

@Simperfit
Copy link
ContributorAuthor

Simperfit commentedOct 30, 2017 via email

I think it's for 4.1 since it's a new featureLe lun. 30 oct. 2017 à 19:36, Nicolas Grekas <notifications@github.com> aécrit :
…
For which branch is this PR? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24750 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADSq8kpLZvv5kOkFN37xDRa9kmKWFfzyks5sxhcwgaJpZM4QKsHg> .

@nicolas-grekasnicolas-grekas added this to the4.1 milestoneOct 30, 2017
@SimperfitSimperfitforce-pushed thefeautre/expression-validator-string-for-value-message branch 4 times, most recently fromf07dbc6 to8b0e61fCompareNovember 1, 2017 13:58
@fabpot
Copy link
Member

It looks like a bug to me. The current behavior does not make much sense, it "works" by change. Displaying a generic "object" string is never something one would expect, right?

@xabbuh
Copy link
Member

fine for me as a bugfix too

Copy link
Contributor

@ogizanagiogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Agreed too 👍

@SimperfitSimperfitforce-pushed thefeautre/expression-validator-string-for-value-message branch from8b0e61f to7dac528CompareDecember 1, 2017 17:16
@SimperfitSimperfit changed the base branch frommaster to2.7December 1, 2017 17:16
@Simperfit
Copy link
ContributorAuthor

rebased to 2.7

@fabpot
Copy link
Member

Thank you@Simperfit.

@fabpotfabpot merged commit7dac528 intosymfony:2.7Dec 1, 2017
fabpot added a commit that referenced this pull requestDec 1, 2017
…G (Simperfit)This PR was merged into the 2.7 branch.Discussion----------[Validator] ExpressionValidator should use OBJECT_TO_STRING…value in message| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#24595| License       | MIT| Doc PR        | Will do.Commits-------7dac528 [Validator] ExpressionValidator should use OBJECT_TO_STRING to allow value in message
This was referencedDec 4, 2017
This was referencedDec 4, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasdunglas approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

7 participants

@Simperfit@nicolas-grekas@fabpot@xabbuh@dunglas@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp