Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[VarDumper] HtmlDumper: fix collapsing nodes with depth < maxDepth#24747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromogizanagi:fix/3.4/var_dumper/html_dumper_root_node
Oct 29, 2017
Merged

[VarDumper] HtmlDumper: fix collapsing nodes with depth < maxDepth#24747

fabpot merged 1 commit intosymfony:3.4fromogizanagi:fix/3.4/var_dumper/html_dumper_root_node
Oct 29, 2017

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagiogizanagi commentedOct 29, 2017
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes (failures unrelated)
Fixed ticketsN/A
LicenseMIT
Doc PRN/A

This error happens since#23967:

(index):3 Uncaught TypeError: Cannot read property 'substr' of null

var r = doc.getElementById(a.getAttribute('href').substr(1)),

when trying to collapse the root node (or more precisely, the nodes with a depth <= maxDepth) because it misses one of thesf-dump-expanded/sf-dump-compact classes which are necessary for the toggling to work.

@ogizanagiogizanagi changed the title[VarDumper] Fix collapsing nodes with depth < maxDepth[VarDumper] HtmlDumper: fix collapsing nodes with depth < maxDepthOct 29, 2017
@ogizanagiogizanagi added this to the3.4 milestoneOct 29, 2017
@fabpot
Copy link
Member

Thank you@ogizanagi.

@fabpotfabpot merged commita1863c3 intosymfony:3.4Oct 29, 2017
fabpot added a commit that referenced this pull requestOct 29, 2017
…maxDepth (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[VarDumper] HtmlDumper: fix collapsing nodes with depth < maxDepth| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass?   | yes (failures unrelated)| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/AThis error happens since#23967:> (index):3 Uncaught TypeError: Cannot read property 'substr' of nullhttps://github.com/symfony/symfony/blob/98dae3edb1ba8fa35c06a8c9a459e0ffb9105826/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php#L325when trying to collapse the root node (or more precisely, the nodes with a depth <= maxDepth) because it misses one of the `sf-dump-expanded`/`sf-dump-compact` classes which are necessary for the toggling to work.Commits-------a1863c3 [VarDumper] HtmlDumper: fix collapsing nodes with depth <= maxDepth
@ogizanagiogizanagi deleted the fix/3.4/var_dumper/html_dumper_root_node branchOctober 29, 2017 20:56
This was referencedOct 30, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@ogizanagi@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp