Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Do not activate the cache if Doctrine's cache is not present#24743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@sroze
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#24683
LicenseMIT
Doc PRø

Annotations are automatically enabled when thedoctrine/annotations package is around. These annotations are enabled with thephp_array cache by default, which requiredoctrine/cache.

This PR allow this scenario to happen by disabling the annotation cache whendoctrine/cache is not present.

manelio reacted with thumbs up emoji
@sroze
Copy link
ContributorAuthor

Failures are un-related. But related with the timezone change and VarDumper (wink wink@nicolas-grekas)

@fabpot
Copy link
Member

Thank you@sroze.

@fabpotfabpot merged commitc5c7a23 intosymfony:3.4Oct 29, 2017
fabpot added a commit that referenced this pull requestOct 29, 2017
…cache is not present (sroze)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Do not activate the cache if Doctrine's cache is not present| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#24683| License       | MIT| Doc PR        | øAnnotations are automatically enabled when the `doctrine/annotations` package is around. These annotations are enabled with the `php_array` cache by default, which require `doctrine/cache`.This PR allow this scenario to happen by disabling the annotation cache when `doctrine/cache` is not present.Commits-------c5c7a23 Do not activate the cache if Doctrine's cache is not present
@srozesroze deleted the issue-24683-cache-none-if-no-doctrine-cache branchOctober 29, 2017 23:15
This was referencedOct 30, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@weaverryanweaverryanweaverryan approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sroze@fabpot@weaverryan@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp