Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Bridge\Twig] Remove use of spaceless#24727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketshttps://github.com/symfony/symfony/pull/24711/files#r147559715
LicenseMIT
Doc PR-

ping@fabpot@arkste

@nicolas-grekas
Copy link
MemberAuthor

@arkste please make this patch yours :)

@vudaltsov
Copy link
Contributor

@nicolas-grekas , this is because{% spaceless %} is slower?

@nicolas-grekas
Copy link
MemberAuthor

@vudaltsov yes, see linked comment

fabpot added a commit that referenced this pull requestOct 30, 2017
…y & remove spaceless (arkste)This PR was squashed before being merged into the 3.4 branch (closes#24728).Discussion----------[Bridge\Twig] fix bootstrap checkbox_row to render properly & remove spaceless| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#24711| License       | MIT| Doc PR        | -As discussed in#24711 i reverted the change i did in `bootstrap_3_layout.html.twig` (which caused an unnecessary empty div-container in the vertical-layout), added the `checkbox_row` block to the `bootstrap_3_horizontal_layout.html.twig` and removed `spaceless` (as proposed in#24727).since i added `{#--#}` in bootstrap 3, i did the same for the same horizontal blocks in bootstrap 4 as well.I moved the `form_label_class` & `form_group_class` blocks to the top of `bootstrap_3_horizontal_layout.html.twig` & `bootstrap_4_horizontal_layout.html.twig`, this should improve DX as they were spreaded across the file.#24702 affected the bootstrap 4 horizontal layout as well, so i added the `checkbox_row` block to bootstrap 4 too.ping@fabpot@nicolas-grekasCommits-------f84749f [Bridge\Twig] fix bootstrap checkbox_row to render properly & remove spaceless
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@arkstearkstearkste approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas@vudaltsov@arkste@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp