Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] Mark new methods on Response as final#24723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromnicolas-grekas:req-deprec
Oct 29, 2017

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

@fabpot
Copy link
Member

Why not use the final keyword instead of the annotation?

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedOct 28, 2017•
edited
Loading

Because I really dislike the keyword: it's technically imperative, while we only need to state intend (like the private keyword allows).

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commita913f70 intosymfony:3.4Oct 29, 2017
fabpot added a commit that referenced this pull requestOct 29, 2017
…nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[HttpFoundation] Mark new methods on Response as final| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Commits-------a913f70 [HttpFoundation] Mark new methods on Response as final
@nicolas-grekasnicolas-grekas deleted the req-deprec branchNovember 4, 2017 11:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp