Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Add the possibility to disable assets via xml#24706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@renatomefi
Copy link
Contributor

@renatomefirenatomefi commentedOct 27, 2017•
edited
Loading

QA
Branch?3.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsno
LicenseMIT
Doc PRno
  • When trying to disable the assets using xml configuration I realized it wasn't possible, this patch fixes and tests it
  • Also added extra tests since the assets being disabled was being tested on both php and yaml Extension tests

@renatomefirenatomefiforce-pushed thefix/disable-assets-via-xml branch 2 times, most recently fromdf5822e to0b9258dCompareOctober 27, 2017 13:20
@chalasrchalasr added this to the3.3 milestoneOct 27, 2017
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should be merged on 3.3, the lowest maintained branch where the assets configuration can be enabled in other formats.

@renatomefi
Copy link
ContributorAuthor

@chalasr thanks, will do it shortly

@renatomefirenatomefiforce-pushed thefix/disable-assets-via-xml branch from0b9258d to24d9375CompareOctober 27, 2017 13:37
@renatomefirenatomefi changed the base branch frommaster to3.3October 27, 2017 13:37
@renatomefirenatomefiforce-pushed thefix/disable-assets-via-xml branch from24d9375 to44588faCompareOctober 27, 2017 13:38
@renatomefirenatomefiforce-pushed thefix/disable-assets-via-xml branch from44588fa to8579e24CompareOctober 27, 2017 13:50
@renatomefi
Copy link
ContributorAuthor

@chalasr all done! :)

@nicolas-grekas
Copy link
Member

Thank you@renatomefi.

@nicolas-grekasnicolas-grekas merged commit8579e24 intosymfony:3.3Oct 28, 2017
nicolas-grekas added a commit that referenced this pull requestOct 28, 2017
…s via xml (renatomefi)This PR was merged into the 3.3 branch.Discussion----------[DependencyInjection] Add the possibility to disable assets via xml| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | no| License       | MIT| Doc PR        | no- When trying to disable the assets using xml configuration I realized it wasn't possible, this patch fixes and tests it- Also added extra tests since the assets being disabled was being tested on both php and yaml Extension testsCommits-------8579e24 [FrameworkBundle] Allow to disable assets via framework:assets xml configuration
@chalasr
Copy link
Member

@renatomefi Congrats for your first contrib on Symfony! Nice PR, well done.

@renatomefi
Copy link
ContributorAuthor

Thank you@chalasr :)

This was referencedOct 30, 2017
@fabpotfabpot mentioned this pull requestNov 10, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@renatomefi@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp