Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] Fix caching of session-enabled pages#24691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedOct 25, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24690 |
| License | MIT |
| Doc PR | - |
| { | ||
| $options +=array( | ||
| 'cache_limiter' =>'private_no_expire', | ||
| 'cache_expire' =>0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can't you then use cache_limiter => nocache directly. The only difference is that it also sets no-store, meaning no conditional requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No-store is too aggressive to me, conditional requests are fine, aren't they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should be yeah.
Tobion commentedOct 26, 2017
Thank you@nicolas-grekas. |
…olas-grekas)This PR was merged into the 3.4 branch.Discussion----------[HttpFoundation] Fix caching of session-enabled pages| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24690| License | MIT| Doc PR | -Commits-------572e02c [HttpFoundation] Fix caching of session-enabled pages