Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Fix FormEvents::* constant and value matching#24631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dmaicher commentedOct 19, 2017
Should this be mentioned inside |
yceruto commentedOct 19, 2017
Thanks@dmaicher, done. |
fe514e0 to0ee856aCompareyceruto commentedOct 19, 2017
Thanks a lot@javiereguiluz, much better! :) |
| * The values of the `FormEvents::*` constants have been updated to match the | ||
| constant names. You should only update your application if you relied on the | ||
| constant values instead of their names. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This will cause UPGRADE-4.0 in master and 3.4 going out of sync no? Which btw is already happening (https://www.diffchecker.com/5W6GeCnZ).. again :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So the upgrade entry should be updated in 3.4 too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes, it should be synchronized
fabpot commentedOct 19, 2017
Thank you@yceruto. |
…yceruto, javiereguiluz)This PR was merged into the 4.0-dev branch.Discussion----------[Form] Fix FormEvents::* constant and value matching| Q | A| ------------- | ---| Branch? | 4.0| Bug fix? | no| New feature? | no| BC breaks? | yes (ppl rely on const value directly, very weird)| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24615| License | MIT| Doc PR | ->#24615 (comment) by@stof:Yeah, I think we could change this in 4.0 without a big impact (btw, I think our BC policy even allows it for this case).There is one case where people will use the event name rather than the constant: the kernel.event_listener tag (and recent versions can even use the constant in YAML files). But this won't be the case for this event, as form events are not dispatched in the main dispatcher anyway.Commits-------944931a Minor reword0ee856a Update UPGRADE-4.0.md0fc2282 fix the constant value to be consistent with the name
This PR was merged into the 3.4 branch.Discussion----------Synchronizing Upgrade 4.0 notes in 3.4| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24631 (comment)| License | MIT| Doc PR | -Commits-------c4f64a6 Update UPGRADE-4.0.md
Uh oh!
There was an error while loading.Please reload this page.