Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Fix missing BC layer for AbstractGuardAuthenticator::getCredentials()#24624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedOct 19, 2017
Do we have a deprecation message when not implementing the new interface btw ? I don't see it in this code. |
chalasr commentedOct 19, 2017
@stof we havehttps://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Security/Guard/GuardAuthenticatorInterface.php#L32 which should be enough (per#16835 (comment)). |
weaverryan left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Very tricky :)
nicolas-grekas commentedOct 24, 2017
Thank you@chalasr. |
…ator::getCredentials() (chalasr)This PR was merged into the 3.4 branch.Discussion----------[Security] Fix missing BC layer for AbstractGuardAuthenticator::getCredentials()| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aIf a guard authenticator extends `AbstractGuardAuthenticator` and returns `null` from `getCredentials()`, an `\UnexpectedValueException` is thrown when upgrading to 3.4 because the abstract already implements the new interface.This triggers a deprecation notice instead.Commits-------b6bb84b [Security] Fix BC layer for AbstractGuardAuthenticator subclasses
If a guard authenticator extends
AbstractGuardAuthenticatorand returnsnullfromgetCredentials(), an\UnexpectedValueExceptionis thrown when upgrading to 3.4 because the abstract already implements the new interface.This triggers a deprecation notice instead.