Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Prefer line formatter on missing cli dumper#24598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Prefer line formatter on missing cli dumper#24598
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The console formatter does a better job, unless the VarDumper componentis missing, in which case you will not see the "context" or "extra" keysand the LineFormatter should be preferred.
| */ | ||
| protectedfunctiongetDefaultFormatter() | ||
| { | ||
| if (!class_exists(CliDumper::class)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I did not find a way to test this (other than change the namespace of the test to match the one of the class but I'm don't think that would be ok with you).
greg0ire commentedOct 18, 2017
Can anyone fix the labels? |
nicolas-grekas commentedOct 24, 2017
Thank you@greg0ire. |
This PR was merged into the 3.3 branch.Discussion----------Prefer line formatter on missing cli dumper| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | none, butclosessymfony/recipes#145| License | MIT| Doc PR | n/aThe console formatter does a better job, unless the VarDumper componentis missing, in which case the LineFormatter should be preferred.Commits-------574f9f5 Prefer line formatter on missing cli dumper
Uh oh!
There was an error while loading.Please reload this page.
The console formatter does a better job, unless the VarDumper component
is missing, in which case the LineFormatter should be preferred.