Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Username and password in basic auth are allowed to contain '.'#24589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromrquadling:2.3
Oct 18, 2017

Conversation

@rquadling
Copy link
Contributor

Initially reported by Fede Isas inbeberlei/assert#234

QA
Branch?2.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

@rquadling
Copy link
ContributorAuthor

Ahh. 2.3 is the first version to validate the basic auth part of a url. But that is failing due to the PHP5.3. Should I have made a PR against 2.7?

@chalasr
Copy link
Member

Yes, 2.7 is the lowest branch that is still maintained. 2.3 isn't maintained anymore.
It's not too late, you can rebase your branch against 2.7 and change the target branch of your PR (https://github.com/blog/2224-change-the-base-branch-of-a-pull-request).

@fabpotfabpot changed the base branch from2.3 to2.7October 18, 2017 14:20
@fabpot
Copy link
Member

Thank you@rquadling.

@fabpotfabpot merged commite5d57dd intosymfony:2.7Oct 18, 2017
fabpot added a commit that referenced this pull requestOct 18, 2017
… '.' (Richard Quadling)This PR was merged into the 2.7 branch.Discussion----------Username and password in basic auth are allowed to contain '.'Initially reported by Fede Isas inbeberlei/assert#234| Q             | A| ------------- | ---| Branch?       | 2.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Commits-------e5d57dd Username and password in basic auth are allowed to contain '.'
@rquadlingrquadling deleted the 2.3 branchOctober 18, 2017 15:28
@rquadling
Copy link
ContributorAuthor

Thank's to@fedeisas.

This was referencedOct 30, 2017
This was referencedNov 10, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rquadling@chalasr@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp