Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Catching deprecations in isolated tests always adds to the Legacy group#24568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
alexpott commentedOct 15, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24567 |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
alexpott commentedOct 16, 2017
I've been trying to work out how to test this. Looking at the existing tests, I'm not sure \Symfony\Bridge\PhpUnit\Tests\ProcessIsolationTest tests what it thinks it does. Because if you change the expected deprecation message then it does not fail. I think this is because we're not actually adding the deprecation listener. |
alexpott commentedOct 16, 2017
Here's a related PR that might make this easier to test.#24575 |
…(xabbuh)This PR was merged into the 3.3 branch.Discussion----------[PhpUnitBridge] fix deprecation triggering test detection| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24548 (comment),#24568| License | MIT| Doc PR |Commits-------da617e8 fix deprecation triggering test detection