Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix PHP 7.2 tests on master branch#24515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedOct 11, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | not yet |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| -php:7.1.3 | ||
| -php:7.1 | ||
| env:deps=high | ||
| -php:7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is meant to be reverted, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes, just for testing now
stof commentedOct 11, 2017
Looks weird to have@Simperfit and@sroze approving the PR at a time it is totally not mergeable... |
nicolas-grekas commentedOct 11, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
On 7.2:
If someone wants to investigate, help welcomed :) |
Simperfit commentedOct 11, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@nicolas-grekas Did you merge the one we did back to master ? it's the same thing |
nicolas-grekas commentedOct 11, 2017
Yes I did, so this is some leftover. |
Simperfit commentedOct 11, 2017
Both the ini's one should not be hard to fix (I think it's the same error as the other PR). About the Process components that hang, I could help you debugging if you want to. @stof I approuved this PR because I though (maybe, too fast) that this will be working directly since we already worked on it. Sorry. |
stof commentedOct 11, 2017
@Simperfit removing testing on PHP 7.1 cannot be approved as is anyway. |
sroze commentedOct 11, 2017
@nicolas-grekas Interestingly I see it the other way around:
|
nicolas-grekas commentedOct 11, 2017
If it hangs locally with HttpFoundation, it may be related to an obsolete phpunit bridge. Try removing the |
sroze commentedOct 11, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Doesn't seam like it, I've |
sroze commentedOct 11, 2017
Looks like all the tests tagged |
nicolas-grekas commentedOct 11, 2017
|
This PR was squashed before being merged into the 4.0-dev branch (closes#24516).Discussion----------[Process] Fix broken tests for PHP 7.2| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | no| Fixed tickets |#24524,#24515| License | MIT| Doc PR | øFollowing#24515, trying to fix Process tests with PHP 7.2Commits-------b410a36 [Process] Fix broken tests for PHP 7.2