Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI] Throw accurate failures when accessing removed services#24484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromnicolas-grekas:collect-privates
Oct 10, 2017

Conversation

nicolas-grekas
Copy link
Member

QA
Branch?3.4
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#24444
LicenseMIT
Doc PR-

See linked issue.
This will throw a useful message when accessing a removed service.
When setting a removed service, a deprecation notice will be thrown also so that in master we can throw an exception then.

@sroze
Copy link
Contributor

sroze commentedOct 8, 2017•
edited
Loading

Shouldn't we keep these synthetic and removed IDs in the container only for debug environments? Because here the value is only DX and the container is in theory taking more memory than before.

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedOct 8, 2017•
edited
Loading

Introducing a different behavior between debug and non-debug is something that could led to subtle bugs, so should be prevented as much as possible.
Fortunately, the reason why you asked for it does not exist in practice: removed ids are split in a separate file that is loaded on demand, and the number of synthetic ids is very small.

sroze reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commitfe7f26d intosymfony:3.4Oct 10, 2017
fabpot added a commit that referenced this pull requestOct 10, 2017
…rvices (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[DI] Throw accurate failures when accessing removed services| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#24444| License       | MIT| Doc PR        | -See linked issue.This will throw a useful message when accessing a removed service.When setting a removed service, a deprecation notice will be thrown also so that in master we can throw an exception then.Commits-------fe7f26d [DI] Throw accurate failures when accessing removed services
@nicolas-grekasnicolas-grekas deleted the collect-privates branchOctober 10, 2017 07:42
This was referencedOct 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

4 participants
@nicolas-grekas@sroze@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp