Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
storage session pdo for postgres fix#24457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // delete the session records that have expired | ||
| $sql ="DELETE FROM$this->table WHERE$this->lifetimeCol+$this->timeCol < :time"; | ||
| $sql ="DELETE FROM$this->table WHERE$this->lifetimeCol< :time -$this->timeCol"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
isn't is the same?a + b < c ===a < c - b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no, in postgres
a and b - integer type (32 bit)
a+b > integer (2^32/2) - it's error
a-b <= integer and accepted by postgres
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this problem in postgres only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is it possible to use unsigned types? or larger types e.g. long (64 bits instead of 32)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Creating tables is in the same package. But to increase the amount of data due to improper use is incorrect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Moreover, the sessional table contains a lot of records, and the losses will be large
| ========= | ||
| * PdoSessionHandler changes | ||
| - bugfix timestamp integer out of range in Postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this should be removed, we dont alter this file for bug fixes
mxp100 commentedOct 12, 2017
tests red for old version of symfony((( |
Tobion commentedOct 12, 2017
Symfony 2.6 is not maintained anymore. Should be rebaed against 2.7 |
mxp100 commentedOct 16, 2017
mxp100 commentedOct 16, 2017
please review this pull request, rebase from 2.6 to 2.7 to long time... |
This PR was merged into the 2.7 branch.Discussion----------pdo session fix| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24456| License | MIT| Doc PR |Fix PDO session timestamp out of range for postgres. (branch from 2.7)P.S. please delete this pull#24457Commits-------56b29a7 pdo session fix
This PR was merged into the 2.7 branch.Discussion----------pdo session fix| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #24456| License | MIT| Doc PR |Fix PDO session timestamp out of range for postgres. (branch from 2.7)P.S. please delete this pullsymfony/symfony#24457Commits-------56b29a754c pdo session fix
Fixed issue, this error in 2.6+ versions