Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Escape command usage#24455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:2.7fromsroze:bug-24225-escape-command-usage
Oct 8, 2017

Conversation

@sroze
Copy link
Contributor

@srozesroze commentedOct 6, 2017•
edited
Loading

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#24225
LicenseMIT
Doc PRø

Escape the console usage to prevent arguments namedinfo or similar to be formatted.

@ro0NL
Copy link
Contributor

What about markdown formatter? should we use htmlspecialchars there?

@sroze
Copy link
ContributorAuthor

@ro0NL I'm not sure we should change anything on the Markdown usage for now, I don't see any issue with such arguments.

@ro0NL
Copy link
Contributor

ro0NL commentedOct 6, 2017•
edited
Loading

AFAIK markdown will render it as HTML tags;

<argument>       # shown as HTML; thus not visible`<argument>`     # shown as code&lt;argument&gt; # shown as text

If we already quote using backticks we're good :)

edit:https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Tests/Fixtures/command_2.md looks good already, i think we're fine :)

Copy link
Contributor

@ro0NLro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should patch 2.7 instead.

@xabbuhxabbuh added this to the3.4 milestoneOct 6, 2017
@srozesrozeforce-pushed thebug-24225-escape-command-usage branch from5b562d5 toef650ddCompareOctober 7, 2017 11:18
@sroze
Copy link
ContributorAuthor

ping@nicolas-grekas

@chalasr
Copy link
Member

I also think this should be merged as a bugfix in 2.7.@sroze Can you retarget and rebase?

@srozesrozeforce-pushed thebug-24225-escape-command-usage branch fromef650dd to2141056CompareOctober 8, 2017 12:00
@srozesroze changed the base branch from3.4 to2.7October 8, 2017 12:00
@sroze
Copy link
ContributorAuthor

Good point.@chalasr rebased and changed target 👍

@chalasr
Copy link
Member

Thank you@sroze.

@chalasrchalasr merged commit2141056 intosymfony:2.7Oct 8, 2017
chalasr pushed a commit that referenced this pull requestOct 8, 2017
This PR was merged into the 2.7 branch.Discussion----------[Console] Escape command usage| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#24225| License       | MIT| Doc PR        | øEscape the console usage to prevent arguments named `info` or similar to be formatted.Commits-------2141056 Escape command usage when displaying it in the text descriptor
@srozesroze deleted the bug-24225-escape-command-usage branchOctober 8, 2017 12:20
This was referencedNov 10, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@ro0NLro0NLro0NL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@sroze@ro0NL@chalasr@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp