Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Session] remove deprecated session handlers#24447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Tobion commentedOct 5, 2017
| } | ||
| } | ||
| public function testWriteWhenUsingExpiresField() |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this test doing the same as the one above. sometime in the past (symfony 2?) the expiry_field option seemed to be optional. but that is not the case anymore
f83c826 to0a7af3fCompare This was referencedOct 5, 2017
fabpot approved these changesOct 5, 2017
Thank you@Tobion. |
fabpot added a commit that referenced this pull requestOct 5, 2017
This PR was merged into the 4.0-dev branch.Discussion----------[Session] remove deprecated session handlers| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | yes| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#8486Removes deprecated session handler from#24389,#24438 and#24443Commits-------0a7af3f [Session] remove deprecated session handlers
fabpot added a commit that referenced this pull requestOct 5, 2017
…ssions (Tobion)This PR was merged into the 2.7 branch.Discussion----------[Session] fix MongoDb session handler to gc all expired sessions| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |MongoDB session handler `gc` wrongly only deleted one random expired session instead of all of them.Care when merging to master as this will conflict with#24447Commits-------e6895bf [Session] fix MongoDb session handler to gc all expired sessions
xabbuh added a commit to symfony/symfony-docs that referenced this pull requestOct 13, 2017
This PR was merged into the master branch.Discussion----------Update outdated session documentation with SF 4The PHP 5.3 compatibilty and proxy logic has been removed insymfony/symfony#24338The MemcacheSessionHandler is removed withsymfony/symfony#24447Commits-------bd765c1 Update outdated session documentation with SF 4
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Removes deprecated session handler from#24389,#24438 and#24443