Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Change datetime to datetime-local for HTML5 datetime input#24401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedOct 2, 2017
Is browser support good enough? |
ogizanagi commentedOct 2, 2017
Anyway, isn't it a BC break? JS apps may rely on |
stof commentedOct 2, 2017
However, the HTML5_FORMAT constant has the timezone included in the format. So it should be updated for |
xabbuh commentedOct 4, 2017
Is this enough? I mean is the format in which data is sent by browsers the same as it was meant to with the old |
Tobion commentedOct 4, 2017
From my short test, it seems Chrome submits the |
Tobion left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
html5 constant and description
pierredup commentedOct 4, 2017
Would it not be considered a BC break to change the value of a constant? |
simPod commentedDec 31, 2017
What's the status of this? Can I help? |
nicolas-grekas commentedFeb 4, 2018
@pierredup let's do the change as requested by@Tobion /@stof |
f2b7874 to31c9c1eComparenicolas-grekas commentedMar 19, 2018
@Tobion aren't we ready here? |
fabpot commentedMar 20, 2018
Thank you@pierredup. |
…e input (pierredup)This PR was merged into the 2.7 branch.Discussion----------[Form] Change datetime to datetime-local for HTML5 datetime input| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | Unknown| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24307| License | MIT| Doc PR | N/AChange the input type from datetime to datetime-local for HTML5 date input (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime)Commits-------802c67c Change datetime input to datetime-local
Change the input type from datetime to datetime-local for HTML5 date input (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime)