Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Register a NullLogger from test kernels#24385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromogizanagi:tests/null_logger
Sep 30, 2017
Merged

[FrameworkBundle] Register a NullLogger from test kernels#24385

fabpot merged 1 commit intosymfony:3.4fromogizanagi:tests/null_logger
Sep 30, 2017

Conversation

ogizanagi
Copy link
Contributor

@ogizanagiogizanagi commentedSep 30, 2017
edited
Loading

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsN/A
LicenseMIT
Doc PRN/A

Relates to#24300

This will avoid unnecessary output on Travis or when running FrameworkBundle tests locally:

but also needed for anyone running functional tests on their project and using the default logger, in order to not get garbage output.

Do we need to find a more generic solution (like exposing aframework.default_logger option so users can set it to false for test)? Or just documenting this?

@fabpot
Copy link
Member

Documentation sounds good for now. In any case,#24300 will need some tweaks. I've tested in real-life, and this does not work well IMHO.

@fabpot
Copy link
Member

Thank you@ogizanagi.

@fabpotfabpot merged commitc109dcd intosymfony:3.4Sep 30, 2017
fabpot added a commit that referenced this pull requestSep 30, 2017
…s (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Register a NullLogger from test kernels| Q             | A| ------------- | ---| Branch?       | 3.4 <!-- see comment below -->| Bug fix?      | no| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/ARelates to#24300This will avoid unnecessary output on Travis or when running FrameworkBundle tests locally:- before:https://travis-ci.org/symfony/symfony/jobs/281624658#L3594-L3635- after:https://travis-ci.org/symfony/symfony/jobs/281643868#L3599-L3617but also needed for anyone running functional tests on their project and using the default logger, in order to not get garbage output.Do we need to find a more generic solution (like exposing a `framework.default_logger` option so users can set it to false for test)? Or just documenting this?Commits-------c109dcd [FrameworkBundle] Register a NullLogger from test kernels
@ogizanagiogizanagi deleted the tests/null_logger branchSeptember 30, 2017 13:45
ogizanagi added a commit to Elao/PhpEnums that referenced this pull requestNov 8, 2017
This PR was merged into the 1.x-dev branch.Discussion----------Update symfony 4 compatibilityTODO:- [x] Update tests to use new PHPUnit namespaces- [x] Fix phpunit version used through env var- [x] Inject a `NullLogger` (seesymfony/symfony#24385)Commits-------64fc69d Use new PhpUnit namespacesa4705a5 Inject a NullLogger for integration tests46e775c Moar travis changese438be5 Update symfony 4 compatibility
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

3 participants
@ogizanagi@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp