Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

removed useless PHPDoc#24342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
OskarStark wants to merge4 commits intosymfony:2.7fromOskarStark:patch-2
Closed

removed useless PHPDoc#24342

OskarStark wants to merge4 commits intosymfony:2.7fromOskarStark:patch-2

Conversation

@OskarStark
Copy link
Contributor

@OskarStarkOskarStark commentedSep 27, 2017•
edited
Loading

QA
Branch?2.7
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PRn/a

sstok and mvhirsch reacted with thumbs up emoji
@OskarStark
Copy link
ContributorAuthor

@lyrixx
Copy link
Member

Yes please

@OskarStarkOskarStark changed the titleremoved useless PHPDoc descriptionremoved useless PHPDocSep 27, 2017
@OskarStarkOskarStark changed the titleremoved useless PHPDoc[WIP] removed useless PHPDocSep 27, 2017
@ogizanagi
Copy link
Contributor

It should start by targeting the lowest maintained branch (i.e 2.7), not 3.3. :)

@ogizanagiogizanagi added this to the2.7 milestoneSep 27, 2017
@OskarStarkOskarStark changed the title[WIP] removed useless PHPDocremoved useless PHPDocSep 27, 2017
@OskarStark
Copy link
ContributorAuthor

It should start by targeting the lowest maintained branch (i.e 2.7), not 3.3. :)

can you do this or shall I switch the branch?

@Simperfit
Copy link
Contributor

You should do it since it will lead to a rebase

OskarStark reacted with thumbs up emoji

@OskarStarkOskarStark changed the base branch from3.3 to2.7September 28, 2017 06:36
@OskarStarkOskarStark changed the base branch from2.7 to3.3September 28, 2017 06:36
@OskarStarkOskarStark changed the base branch from3.3 to2.7September 28, 2017 06:42
@OskarStarkOskarStark changed the titleremoved useless PHPDoc[WIP] removed useless PHPDocSep 28, 2017
@OskarStark
Copy link
ContributorAuthor

@OskarStarkOskarStark changed the title[WIP] removed useless PHPDocremoved useless PHPDocSep 28, 2017
@OskarStark
Copy link
ContributorAuthor

It should start by targeting the lowest maintained branch (i.e 2.7), not 3.3. :)

done@ogizanagi

@ogizanagi
Copy link
Contributor

@OskarStark: There are still some tests failing.

@OskarStark
Copy link
ContributorAuthor

@OskarStark: There are still some tests failing.

fabbot is failing, but not related to this PR
AppVeyor is green
travis failed, due to now output for 10 minutes, I restarted via --force push

@nicolas-grekas
Copy link
Member

can you still fix fabbot failure please?

@OskarStark
Copy link
ContributorAuthor

can you still fix fabbot failure please?

done@nicolas-grekas 👍

@OskarStark
Copy link
ContributorAuthor

Hmm, I don't know why they are failing... 😢

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

travis error is a false positive

@OskarStark
Copy link
ContributorAuthor

travis error is a false positive

good to know, thank you@nicolas-grekas

fabpot added a commit that referenced this pull requestSep 30, 2017
This PR was squashed before being merged into the 2.7 branch (closes#24342).Discussion----------removed useless PHPDoc| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | no| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        | n/aCommits-------5ee9043 removed useless PHPDoc
@fabpotfabpot closed thisSep 30, 2017
@OskarStarkOskarStark deleted the patch-2 branchOctober 2, 2017 04:59
fabpot added a commit that referenced this pull requestOct 4, 2017
This PR was merged into the 3.4 branch.Discussion----------[DI] remove inheritdoc from dumped container| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |The inheritdoc without adding text is pointless on it's own as any decent IDE will show that those methods are overwriting the base method. This removes it from the dumped container to remove memory and generation time. This goes in the same direction as#23673,#18048 and#24342It does not affect phpdocs of the compiled container that might actually be useful (factory methods of services explaining if the service is private, shared etc.).Commits-------d779845 [DI] remove inheritdoc from dumped container
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull requestMar 25, 2018
This PR was squashed before being merged into the 2.7 branch (closessymfony#24342).Discussion----------removed useless PHPDoc| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | no| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks?    | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        | n/aCommits-------5ee9043 removed useless PHPDoc
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxlyrixx approved these changes

@stofstofstof approved these changes

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

9 participants

@OskarStark@lyrixx@ogizanagi@Simperfit@nicolas-grekas@stof@xabbuh@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp