Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle] Deprecate ACL related code#24318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+315 −46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2496377 to69eb41fComparejaviereguiluz approved these changesSep 25, 2017
| protectedfunctionexecute(InputInterface$input,OutputInterface$output) | ||
| { | ||
| // BC to be removed in 4.0 | ||
| (newSymfonyStyle($input,$outputinstanceof ConsoleOutputInterface ?$output->getErrorOutput() :$output))->warning('Command "init:acl" is deprecated since version 3.4 and will be removed from SecurityBundle in 4.0. Register symfony/acl-bundle and use "acl:init" instead.'); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Register symfony/acl-bundle and use ... ->Install symfony/acl-bundle and use ... ?
| protectedfunctionexecute(InputInterface$input,OutputInterface$output) | ||
| { | ||
| // BC to be removed in 4.0 | ||
| (newSymfonyStyle($input,$outputinstanceof ConsoleOutputInterface ?$output->getErrorOutput() :$output))->warning('Command "acl:set" is deprecated since version 3.4 and will be removed from SecurityBundle in 4.0. Register symfony/acl-bundle instead.'); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Register symfony/acl-bundle instead. ->Install symfony/acl-bundle to use this command. ?
69eb41f tod45e296CompareContributor
ro0NL left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! Looking good :)
gusdecool approved these changesSep 25, 2017
nicolas-grekas approved these changesSep 26, 2017
d45e296 to9d2137dCompare9d2137d toe3b7dc5Compareweaverryan approved these changesSep 26, 2017
Member
fabpot commentedSep 26, 2017
Thank you@chalasr. |
fabpot added a commit that referenced this pull requestSep 26, 2017
This PR was merged into the 3.4 branch.Discussion----------[SecurityBundle] Deprecate ACL related code| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes/no| Fixed tickets | replaces#23811| License | MIT| Doc PR | todoNeedssymfony/acl-bundle#2Commits-------e3b7dc5 [SecurityBundle] Deprecate ACL related code
fabpot added a commit that referenced this pull requestSep 27, 2017
…tion (ogizanagi)This PR was merged into the 3.4 branch.Discussion----------[SecurityBundle] Add missing AclSchemaListener deprecation| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | N/AMissing from#24318Commits-------d43c1f7 [SecurityBundle] Add missing AclSchemaListener deprecation
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needssymfony/acl-bundle#2