Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] Added missing link to profile token#24237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:3.3fromvtsykun:profiler-missing-link
Sep 27, 2017

Conversation

@vtsykun
Copy link
Contributor

QA
Branch?3.3
Bug fix?yes, it was on 3.3.6 (before merge#23676)
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

On v3.3.6 I can open profiles for sub-request on this link
selection_188

But after 3.3.7 it was replaced by links to the controller. In this pull request was added missing link to the profile
selection_186

sstok and ro0NL reacted with thumbs up emoji
@nicolas-grekasnicolas-grekas added this to the3.3 milestoneSep 18, 2017
@javiereguiluz
Copy link
Member

Thank you@vtsykun.

@javiereguiluzjaviereguiluz merged commitc388b25 intosymfony:3.3Sep 27, 2017
javiereguiluz added a commit that referenced this pull requestSep 27, 2017
…tsykun)This PR was merged into the 3.3 branch.Discussion----------[WebProfilerBundle] Added missing link to profile token| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes, it was on 3.3.6 (before merge#23676)| New feature?  | no| BC breaks?    | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -On v3.3.6 I can open profiles for sub-request on this link![selection_188](https://user-images.githubusercontent.com/21358010/30518552-dc6a1f72-9b89-11e7-9d2f-d348846d7285.png)But after 3.3.7 it was replaced by links to the controller. In this pull request was added missing link to the profile![selection_186](https://user-images.githubusercontent.com/21358010/30518572-7a1420c4-9b8a-11e7-8514-098c4ec2c3d6.png)Commits-------c388b25 [WebProfilerBundle] Added missing link to profile token
@vtsykunvtsykun deleted the profiler-missing-link branchSeptember 27, 2017 08:09
@fabpotfabpot mentioned this pull requestOct 5, 2017
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull requestMar 25, 2018
…oken (vtsykun)This PR was merged into the 3.3 branch.Discussion----------[WebProfilerBundle] Added missing link to profile token| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes, it was on 3.3.6 (before mergesymfony#23676)| New feature?  | no| BC breaks?    | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -On v3.3.6 I can open profiles for sub-request on this link![selection_188](https://user-images.githubusercontent.com/21358010/30518552-dc6a1f72-9b89-11e7-9d2f-d348846d7285.png)But after 3.3.7 it was replaced by links to the controller. In this pull request was added missing link to the profile![selection_186](https://user-images.githubusercontent.com/21358010/30518572-7a1420c4-9b8a-11e7-8514-098c4ec2c3d6.png)Commits-------c388b25 [WebProfilerBundle] Added missing link to profile token
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@xabbuhxabbuhxabbuh approved these changes

+2 more reviewers

@ro0NLro0NLro0NL approved these changes

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

8 participants

@vtsykun@javiereguiluz@stof@ro0NL@xabbuh@ogizanagi@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp