Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

added clean option to assets install command#24216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromrobinlehrmann:added-clean-option-assets-install
Dec 7, 2017
Merged

added clean option to assets install command#24216

fabpot merged 1 commit intosymfony:masterfromrobinlehrmann:added-clean-option-assets-install
Dec 7, 2017

Conversation

@robinlehrmann
Copy link

@robinlehrmannrobinlehrmann commentedSep 15, 2017•
edited
Loading

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#24204,#23416
LicenseMIT

OJezu, bmadzar, and anyt reacted with thumbs up emoji
@linaori
Copy link
Contributor

Should probably go into 3.4 as it's a new feature, even though I know why it "broke".

@nicolas-grekas
Copy link
Member

@iltar this tries to remove a behavior change introduced in#23195

@nicolas-grekasnicolas-grekas added this to the2.7 milestoneSep 16, 2017
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedSep 16, 2017•
edited
Loading

So, ping@stof, original reporter of#23177.

@nicolas-grekas
Copy link
Member

I'd propose to reverse the flag, and submit it on 3.4, as a new feature, so that people can opt-out if they want (yes, that'd mean keeping the BC break, I know, let's live with that.)

@robinlehrmannrobinlehrmann changed the base branch from2.7 tomasterNovember 24, 2017 13:37
@xabbuhxabbuh added Feature and removed Bug labelsNov 24, 2017
@xabbuhxabbuh modified the milestones:2.7,4.1Nov 24, 2017
))
->addOption('symlink',null, InputOption::VALUE_NONE,'Symlinks the assets instead of copying it')
->addOption('relative',null, InputOption::VALUE_NONE,'Make relative symlinks')
->addOption('clean',null, InputOption::VALUE_NONE,'Remove the assets of the bundles that no longer exist')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nicolas-grekas suggested the opposite (i.e. having ano-cleanup option or something similar) which would need to be passed if you do not want to have old assets removed.

@robinlehrmann
Copy link
Author

@xabbuh Okay, I changed it. Good point 👍

@fabpot
Copy link
Member

Thank you@robinlehrmann.

@fabpotfabpot merged commit771f11b intosymfony:masterDec 7, 2017
fabpot added a commit that referenced this pull requestDec 7, 2017
…rmann)This PR was merged into the 4.1-dev branch.Discussion----------added clean option to assets install command| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#24204,#23416| License       | MITCommits-------771f11b added clean option to assets install command
@robinlehrmannrobinlehrmann deleted the added-clean-option-assets-install branchDecember 7, 2017 16:22
@fabpotfabpot mentioned this pull requestMay 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

7 participants

@robinlehrmann@linaori@nicolas-grekas@fabpot@Tobion@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp