Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Added an alias for FlashBagInterface in config#24200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tifabien commentedSep 14, 2017
Q | A |
---|---|
Branch? | 3.3 |
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | |
License | MIT |
Doc PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
for 3.4 as a new feature to me
Somewhat related:#11279 and co |
chalasr commentedSep 17, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Regarding#11279, would it make sense to make this service available in AbstractController? (could be for another PR) |
nicolas-grekas commentedSep 18, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@chalasr in practice a |
Indeed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
as a feature in 3.4
Do I need to rebase my branch on top of 3.4 or is it not necessary? |
Thank you@tifabien. |
This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes#24200).Discussion----------Added an alias for FlashBagInterface in config| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------b6b6d31 Added an alias for FlashBagInterface in config