Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added an alias for FlashBagInterface in config#24200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
tifabien wants to merge1 commit intosymfony:3.3fromtifabien:add-flash-bag-alias

Conversation

tifabien
Copy link
Contributor

QA
Branch?3.3
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

for 3.4 as a new feature to me

@fabpot
Copy link
Member

Somewhat related:#11279 and co

@chalasr
Copy link
Member

chalasr commentedSep 17, 2017
edited
Loading

Regarding#11279, would it make sense to make this service available in AbstractController? (could be for another PR)

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedSep 18, 2017
edited
Loading

@chalasr in practice aSession instance is always provided. With this alias ppl could at least type-hint a controller/action argument. Isn't it enough?

@chalasr
Copy link
Member

Indeed!

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

as a feature in 3.4

@tifabien
Copy link
ContributorAuthor

Do I need to rebase my branch on top of 3.4 or is it not necessary?

@nicolas-grekas
Copy link
Member

Thank you@tifabien.

nicolas-grekas added a commit that referenced this pull requestSep 26, 2017
This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes#24200).Discussion----------Added an alias for FlashBagInterface in config| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Commits-------b6b6d31 Added an alias for FlashBagInterface in config
@tifabientifabien deleted the add-flash-bag-alias branchSeptember 28, 2017 11:00
This was referencedOct 18, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

6 participants
@tifabien@fabpot@chalasr@nicolas-grekas@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp