Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Translation] drop MessageSelector support in the Translator#24176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromxabbuh:remove-message-selector
Sep 13, 2017

Conversation

xabbuh
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?yes
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

@xabbuh
Copy link
MemberAuthor

The failure seems to be related to a commit hash that was not propagated from the subtree split of the Translation component to packagist.org.

@fabpot
Copy link
Member

I've updated Packagist, is it better now?

@xabbuhxabbuhforce-pushed theremove-message-selector branch froma5da486 to2028a83CompareSeptember 13, 2017 07:30
@xabbuh
Copy link
MemberAuthor

finally, Travis CI got that change too

@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit2028a83 intosymfony:masterSep 13, 2017
fabpot added a commit that referenced this pull requestSep 13, 2017
…slator (xabbuh)This PR was merged into the 4.0-dev branch.Discussion----------[Translation] drop MessageSelector support in the Translator| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Commits-------2028a83 drop MessageSelector support in the Translator
@xabbuhxabbuh deleted the remove-message-selector branchSeptember 13, 2017 13:57
@fabpotfabpot mentioned this pull requestOct 19, 2017
@flip111
Copy link
Contributor

flip111 commentedOct 24, 2017
edited
Loading

@xabbuh
Copy link
MemberAuthor

@flip111 not sure what you mean, this PR is precisely tagged as a BC break because we removed things that were deprecated before

@flip111
Copy link
Contributor

Yes that's fine, i'm just making a comment as cross-reference ...

@xabbuh
Copy link
MemberAuthor

Please abstain from doing so. This just causes unnecessary noise for everyone having subscribed to the Symfony repository.

flip111 and Nyholm reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

4 participants
@xabbuh@fabpot@flip111@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp