Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Translation] drop MessageSelector support in the Translator#24176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedSep 12, 2017
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | no |
BC breaks? | yes |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | |
License | MIT |
Doc PR |
The failure seems to be related to a commit hash that was not propagated from the subtree split of the Translation component to packagist.org. |
I've updated Packagist, is it better now? |
a5da486
to2028a83
Comparefinally, Travis CI got that change too |
Thank you@xabbuh. |
…slator (xabbuh)This PR was merged into the 4.0-dev branch.Discussion----------[Translation] drop MessageSelector support in the Translator| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------2028a83 drop MessageSelector support in the Translator
flip111 commentedOct 24, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@flip111 not sure what you mean, this PR is precisely tagged as a BC break because we removed things that were deprecated before |
Yes that's fine, i'm just making a comment as cross-reference ... |
Please abstain from doing so. This just causes unnecessary noise for everyone having subscribed to the Symfony repository. |