Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Get KERNEL_CLASS through $_ENV too for KernelTestCase#24113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.3fromyceruto:fix_get_kernel_class
Sep 7, 2017

Conversation

@yceruto
Copy link
Member

@ycerutoyceruto commentedSep 6, 2017•
edited
Loading

QA
Branch?3.3
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketshttps://github.com/symfony/recipes/pull/170/files#diff-793b024840ee04ebdff5e04c2cd44f8cR12
LicenseMIT
Doc PR-

I guess the check could be simplied inmaster with php7+

/cc@nicolas-grekas

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

KERNEL_DIR also should be updated

@ycerutoyceruto changed the title[Tests] Get KERNEL_CLASS through $_ENV too[Tests] Get KERNELCLASS/DIR through $_ENV tooSep 6, 2017
@ycerutoyceruto changed the title[Tests] Get KERNELCLASS/DIR through $_ENV too[Tests] Get KERNEL_CLASS/DIR through $_ENV tooSep 6, 2017
@nicolas-grekasnicolas-grekas changed the title[Tests] Get KERNEL_CLASS/DIR through $_ENV too[FrameworkBundle] Get KERNEL_CLASS/DIR through $_ENV too for KernelTestCaseSep 6, 2017
{
if (isset($_SERVER['KERNEL_CLASS'])) {
if (!class_exists($class =$_SERVER['KERNEL_CLASS'])) {
if (isset($_SERVER['KERNEL_CLASS']) ||isset($_ENV['KERNEL_CLASS'])) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should probably be fixed in 2.7.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removed changes regarding toKERNEL_DIR var only, soKERNEL_CLASS was introduced in3.3.

Copy link
MemberAuthor

@ycerutoycerutoSep 6, 2017•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

See#24115 for2.7

@ycerutoyceruto changed the title[FrameworkBundle] Get KERNEL_CLASS/DIR through $_ENV too for KernelTestCase[FrameworkBundle] Get KERNEL_CLASS through $_ENV too for KernelTestCaseSep 6, 2017
@nicolas-grekasnicolas-grekas added this to the3.3 milestoneSep 7, 2017
nicolas-grekas added a commit that referenced this pull requestSep 7, 2017
…nelTestCase (yceruto)This PR was merged into the 2.7 branch.Discussion----------[FrameworkBundle] Get KERNEL_DIR through $_ENV too for KernelTestCase| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -See#24113Commits-------cf11fb9 Get KERNEL_DIR through $_ENV too for KernelTestCase
@nicolas-grekas
Copy link
Member

Thank you@yceruto.

@nicolas-grekasnicolas-grekas merged commit73cdb68 intosymfony:3.3Sep 7, 2017
nicolas-grekas added a commit that referenced this pull requestSep 7, 2017
…ernelTestCase (yceruto)This PR was merged into the 3.3 branch.Discussion----------[FrameworkBundle] Get KERNEL_CLASS through $_ENV too for KernelTestCase| Q             | A| ------------- | ---| Branch?       | 3.3| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |https://github.com/symfony/recipes/pull/170/files#diff-793b024840ee04ebdff5e04c2cd44f8cR12| License       | MIT| Doc PR        | -I guess the check could be simplied in `master` with php7+/cc@nicolas-grekasCommits-------73cdb68 Get KERNEL_CLASS through $_ENV too
@ycerutoyceruto deleted the fix_get_kernel_class branchSeptember 7, 2017 10:55
@fabpotfabpot mentioned this pull requestSep 11, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot requested changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@yceruto@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp