Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[TwigBridge] Show Twig's loader paths on debug:twig command#24064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
yceruto commentedSep 1, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I have another outputs for this list, which do you prefer?
|
Uh oh!
There was an error while loading.Please reload this page.
ogizanagi commentedSep 1, 2017
For the record, I prefer the current version (A). |
Uh oh!
There was an error while loading.Please reload this page.
stof commentedSep 1, 2017
Outputting namespace first looks better to me (so A), as what is important is the different paths related to a given namespace. Paths used for separate namespaces are irrelevant regarding their order |
yceruto commentedSep 1, 2017
Updated screenshot in description with the latest changes. |
ogizanagi commentedSep 1, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I find using Which of the following outputs would you prefer? My own vote would go to 4 or 5 (but 7's not bad, that's true 😄). |
yceruto commentedSep 1, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
yceruto commentedSep 1, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The problem I see with no row separator is that there is no grouping view per namespace, so one could get confused (missing namespace 😕) |
yceruto commentedSep 1, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
My vote is for 7. |
ro0NL commentedSep 1, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
What about a 7 is nice, agree with@yceruto; you getter a better view of path inheritance per namespace. Tend to prefer edit: on 2nd thought (None) is fine :) |
fabpot commentedSep 5, 2017
Thank you@yceruto. |
…mmand (yceruto)This PR was squashed before being merged into the 3.4 branch (closes#24064).Discussion----------[TwigBridge] Show Twig's loader paths on debug:twig command| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -`bin/console debug:twig`:This information is not displayed anywhere ATM and it should be important to know: * The Twig's namespaces availables * The Twig's paths availables * The order that templates will be loaded ( regarding its namespace -> LOAD PRIORITY ! )So it should help us to debug any issue related to circular templates reference, invalid namespaces, unsuccessful attempt to override a template, etc.WDYT?Commits-------3fdcb40 [TwigBridge] Show Twig's loader paths on debug:twig command

Uh oh!
There was an error while loading.Please reload this page.
bin/console debug:twig:This information is not displayed anywhere ATM and it should be important to know:
So it should help us to debug any issue related to circular templates reference, invalid namespaces, unsuccessful attempt to override a template, etc.
WDYT?