It's perfectly valid to use the Config component without XML files. Thus I suggest to instead handle the missing XML extension case gracefully in theXmlUtils class instead.

@xabbuh I've added extension check toloadFile only, becauselibxml is required byphp7.1 ,convertDomElementToArray has argument with instanceof\DOMElement

FrameworkBundle should have the requirement though, because it depends on XML support.

the requirement should beext-dom btw

@stofext-xml requirements was added in#22676 and as@xabbuh mentioned it's valid use case to usesymfony/config withoutext-xml orext-dom

What@stof means is that the requirement on FrameworkBundle should beext-dom instead ofext-xml, that could be fixed here if you wish to do it.
For Config, we should just throw in XmlUtiils if!extension_loaded('xml') as suggested by@xabbuh .

Btw, this should be rebased on 2.7 and the target branch changed accordingly.

@chalasr it's possible to disable xml and enable dom only, ref.:#24047 (comment), so changing FrameworkBundle requirements fromext-xml toext-dom is quite dangerous

I can put!extension_loaded('dom') in the file, but I didn't done that initially because\Symfony\Component\Config\Util\XmlUtils::phpize is quite useful method :)

@oleg-andreyev the question is whether we need only ext-dom or also ext-xml. If we need ext-xml, the requirement should stay like that.

But anyway, for the config component, it must stay an optional dependency (the component contains many other things not requiring XML)

For Config we should deal withxml only, notdom which is a requirement for FrameworkBundle only. So the check should be!extension_loaded('xml').

I didn't done that initially because \Symfony\Component\Config\Util\XmlUtils::phpize is quite useful method :)

Well, I don't have the code in mind, but ifphpize() can be used without thexml extension, we should not forbid using it, adding the check only where it breaks already ifxml extension not loaded. But I guess it does break, isn't it?

edit: let's let FrameworkBundle as is ifdom doesn't guaranteexml, as said

@chalasr I don't see whereext-dom in requirements for FrameworkBundle.

sum up:

• I've updatedXmlUtils::loadFile because it's using\DOMDocument
• I didn't updateXmlUtils::phpize could be used withoutext-xml orext-dom
• I didn't updateXmlUtils::convertDomElementToArray, because it has input argument\DOMElement $element

The existing tests for this method should be updated to add@requires extension dom (and/or xml) so that the component test suite can be ran even if the extension is not loaded.

add@requires extension dom

@chalasr I'm a bit surprised, but withoutext-dom we won't be able to run phpunit
Ref.:\PHPUnit\Util\Xml::load, lol

@oleg-andreyev fair enough 😅

@oleg-andreyev Can you rebase your branch against 2.7 to see tests green?

Thank you@oleg-andreyev.