Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Fix lazy Memcached connections#23971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 with minor comment (needs rebase also)
| $opt =$client->getOption(\Memcached::OPT_SERIALIZER); | ||
| if (\Memcached::SERIALIZER_PHP !==$opt && \Memcached::SERIALIZER_IGBINARY !==$opt) { | ||
| thrownewCacheException('MemcachedAdapter: "serializer" option must be "php" or "igbinary".'); | ||
| if (get_class($client) ==='Memcached') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yoda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what is yoda here? :)
8641889 tod8c400bComparenicolas-grekas commentedAug 24, 2017
rebase done |
fabpot commentedAug 26, 2017
Thank you@nicolas-grekas. |
This PR was merged into the 3.3 branch.Discussion----------[Cache] Fix lazy Memcached connections| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -By calling methods on the Memcached instance on cache pool initialization, we defeat the purpose of lazy proxies, if anyone wanted to use one.Commits-------d8c400b [Cache] Fix lazy Memcached connections
By calling methods on the Memcached instance on cache pool initialization, we defeat the purpose of lazy proxies, if anyone wanted to use one.